Re: [Xen-devel] [PATCH v3 11/16] xen/arm: move vgic defines to vgic header file

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-04-23 at 16:11 +0100, Julien Grall wrote:
> On 04/23/2014 04:07 PM, Ian Campbell wrote:
> > On Wed, 2014-04-16 at 18:01 +0100, Julien Grall wrote:
> >> Hello Vijaya,
> >>
> >> Thank you for the patch.
> >>
> >> On 04/15/2014 12:17 PM, vijay.kilari@xxxxxxxxx wrote:
> >>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> >>>
> >>> gic.h contains defines of vgic. Move these to vgic
> >>> header file. Also move inline functions and defines
> >>> in vgic.c to vgic.h
> >>
> >> Can you explain in the commit message, why you need to move theses
> >> functions in the header?
> > 
> > Yeah, many of them look like they will really belong in either vgic.c or
> > vgic-v2.c. Which ones are actually used by both the generic and specific
> > code?
> > 
> >>> +static inline int is_vcpu_running(struct domain *d, int vcpuid)
> >>
> >>
> >> The name of the 2 functions and 1 define are too generic. It was fine
> >> internally but not to be exported.
> > 
> > is_vcpu_running is fine IMHO.
> 
> With this name, I don't think this function should belong to vgic.h
> 
> Can it be a common code function (i.e ARM & x86)? Maybe sched.h?

I haven't looked at the implementation to see if it makes sense for x86,
but if so then sched.h is fine. Otherwise some asm header would be fine
too.

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel