Re: [Xen-devel] [PATCH v3 05/11] hvm/hpet: In hpet_save, correctly compute mc64.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.04.14 at 19:42, <dslutz@xxxxxxxxxxx> wrote:
> When the master clock is not enabled, mc64 has the right value.
> 
> Basicly do the same thing as hpet_read_maincounter().
> 
> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

>  xen/arch/x86/hvm/hpet.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c
> index c64c547..0789947 100644
> --- a/xen/arch/x86/hvm/hpet.c
> +++ b/xen/arch/x86/hvm/hpet.c
> @@ -499,7 +499,8 @@ static int hpet_save(struct domain *d, 
> hvm_domain_context_t *h)
>      spin_lock(&hp->lock);
>  
>      /* Write the proper value into the main counter */
> -    hp->hpet.mc64 = hp->mc_offset + guest_time_hpet(hp);
> +    if ( hpet_enabled(hp) )
> +        hp->hpet.mc64 = hp->mc_offset + guest_time_hpet(hp);
>  
>      /* Save the HPET registers */
>      rc = _hvm_init_entry(h, HVM_SAVE_CODE(HPET), 0, HVM_SAVE_LENGTH(HPET));
> -- 
> 1.8.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel