Re: [Xen-devel] [PATCH v3 09/16] xen/arm: use device api to detect GIC version

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-04-15 at 16:47 +0530, vijay.kilari@xxxxxxxxx wrote:
> +static const char * const gicv2_dt_compat[] __initconst =
> +{
> +    "arm,cortex-a15-gic",
> +    "arm,cortex-a9-gic",

This is DT_MATCH_GIC. Please keep using it. Perhaps you will want to
rename it to DT_MATCH_GICV2.

> [...]

> +
> +        rc = device_init(node, DEVICE_GIC, NULL);
> +        if ( !rc )
> +        {
> +            num_gics++;

Please can you add a comment to the affect that we only support one GIC
right now.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel