Re: [Xen-devel] [PATCH v3 03/16] xen/arm: make sgi handling generic

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-04-15 at 18:51 +0100, Julien Grall wrote:
> > +    default:
> > +         gdprintk(XENLOG_WARNING, "Wrong sgi irq mode for sgi %x\n", sgi);
> 
> You can't use gdprintk here as the function may not be used by guest.
> 
> You should replace by dprintk(...). Even better a BUG_ON as this should
> be never reached.

Yes, BUG_ON please.

> >  void smp_send_state_dump(unsigned int cpu)
> > diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
> > index 5d8f7f1..d03b490 100644
> > --- a/xen/include/asm-arm/gic.h
> > +++ b/xen/include/asm-arm/gic.h
> > @@ -50,6 +50,10 @@
> >  #define GICD_SPENDSGIRN (0xF2C/4)
> >  #define GICD_ICPIDR2    (0xFE8/4)
> >  
> > +#define SGI_TARGET_LIST    0
> > +#define SGI_TARGET_OTHERS  1
> > +#define SGI_TARGET_SELF    2
> > +
[..]
> I would also use an enum as we know it's bound.

Yes, please.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel