[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 2/4] GlobalProperty: Display warning about unused -global




On 04/22/14 20:28, Paolo Bonzini wrote:
Il 22/04/2014 19:13, Don Slutz ha scritto:

Even then, I suspect sooner or later machines other than PC and Q35
will be versioned.  At that point we'll probably want QEMU-global
compat_props that automatically apply to all machines, even if a type
is not missing.  I think we should already approximate this behavior
by allowing machine .compat_props where the type doesn't exist.

If I am reading this correctly, this is asking that .compat_props to not
be reported.  This currently happens because of not_used being false
in all C99 struct initializations.

Oh, I see. That's obvious in retrospect, but perhaps a comment can be useful around the definition of the not_used field.


Will add a comment:

/**
 * GlobalProperty:
* @not_used: Track use of a global property. Defaults to false in all C99 struct initializations.
 *
 * This prevents reports of .compat_props when they are not used.
 */

(Not sure if this is the correct formatting.)

   -Don Slutz

Paolo


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.