Re: [Xen-devel] [PATCH v7 05/12] xen/arm: nr_lrs should be uint8_t

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/23/2014 01:47 PM, Ian Campbell wrote:
> On Tue, 2014-04-08 at 16:12 +0100, Stefano Stabellini wrote:
>> A later patch is going to use uint8_t to keep track of LRs.
>> Both GICv3 and GICv2 don't need any more than an uint8_t to keep track
>> of the number of LRs.
> 
> Did you confirm that this doesn't lead to inefficient loading and
> masking stuff on access?
> 
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> If yes then:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Although TBH I'm not sure why unsigned int was so harmful here.

In struct irq_pending (see next patch: #6) the lr is stored using an uint8.

IHMO, the both variable should have the same type to avoid mistake.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel