Re: [Xen-devel] [PATCH] tools: remove /var/run/xenstored from install target

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-04-17 at 19:14 +0100, Ian Jackson wrote:
> Olaf Hering writes ("[PATCH] tools: remove /var/run/xenstored from install 
> target"):
> > xenstored already does "mkdir /var/run/xenstored" on startup, so its not
> > required to create this directory during make install|rpmball.
> > 
> > Without this change installing the resulting xen.rpm will fail on
> > systems where /var/run is a symlink. rpm complains that '/var/run' (the
> > symlink) is already owned by some other system rpm package.
> 
> I think this is right.  Note also that /var/run might be a tmpfs so
> trying to "install" it as a directory isn't right because it might
> vanish on reboot (which is why the startup script creates it too).
> 
> I think it was simply a mistake not to remove the INSTALL_DIR at the
> same time as adding the startup script mkdir.

I've taken this as an Ack (since you acked several other patches with
reference to these comments, so I've assumed the omission here was
unintentional) and also Acked myself + applied.

I have also acked + applied
        tools: remove /var/lock/subsys from install target
        tools/pygrub: remove /var/run/xend/boot from install target
which you did ack as well.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel