[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: add missing break in hwdom_pit_access()

To: Jan Beulich <JBeulich@xxxxxxxx>
From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Date: Wed, 23 Apr 2014 11:56:23 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
Delivery-date: Wed, 23 Apr 2014 10:56:51 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 23/04/14 07:48, Jan Beulich wrote:

Coverity ID 1203045

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>


--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1634,6 +1634,7 @@ int hwdom_pit_access(struct ioreq *ioreq
             outb(ioreq->data, PIT_MODE);
             return 1;
         }
+        break;
 
     case 0x61:
         if ( ioreq->dir == IOREQ_READ )

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

References:
- [Xen-devel] [PATCH] x86: add missing break in hwdom_pit_access()
  - From: Jan Beulich

Prev by Date: Re: [Xen-devel] [PATCH v2 3/4] amd-iommu: disable iommu_hap_pt_share with AMD IOMMUs
Next by Date: Re: [Xen-devel] drjones@xxxxxxxxxx, vkuznets@xxxxxxxxxx, leiwang@xxxxxxxxxx, wshi@xxxxxxxxxx
Previous by thread: [Xen-devel] [PATCH] x86: add missing break in hwdom_pit_access()
Next by thread: [Xen-devel] [PATCH] only use legitimate shift counts in bitmap shifting
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.