Re: [Xen-devel] [PATCH] libxl: libxl__spawn_qdisk_backend closes fds

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-03-18 at 16:23 +0000, Ian Jackson wrote:

> > >      return;
> > >  
> > >  error:
> > >      assert(rc);
> > > -    dmss->callback(egc, dmss, rc);
> > > -    return;
> > > +    goto out;
> > 
> > This jump backwards is kind of strange IMHO, why not just rename the
> > error label to out and use it instead for both the error and non-error
> > exit paths?
> 
> That would be possible, but would lose the assert(rc).  An error
> handling bug elsewhere in the function, which failed to set rc, would
> result in it losing the thread of control.  If we don't think the
> assert is important I don't mind losing it.

The assert is only there to check that we jumped to error on an error,
with a common exit path the assert would be a bit unnecessary I think.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel