[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RFC V2 05/10] libxl_json: introduce parser functions for builtin types
On Wed, Apr 23, 2014 at 11:12:54AM +0100, Ian Campbell wrote: > On Wed, 2014-04-23 at 11:01 +0100, Wei Liu wrote: > > > The aformentioned "calloc" falls into #1 but not this one. > > > > My comment is a bit confusing. The comment here actually refers to all > > the malloc'ed memory in the loop, which will be freed by > > libxl_cpuid_dispose. > > You mean when the caller eventually gets rid of the result, or the error > path here does it? > The former. Caller will regardlessly call dispose_fn of a type, wouldn't it? > I don't think that needs an explicit comment, it's just the expected > behaviour of #1 type allocations. > OK. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |