Re: [Xen-devel] [PATCH] xen: use XEN_BOOT_DIR as xen.gz install location

[Olaf Hering <olaf@xxxxxxxxx>]

On Wed, Apr 23, Jan Beulich wrote:

> >>> On 23.04.14 at 10:00, <olaf@xxxxxxxxx> wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -13,6 +13,7 @@ export BASEDIR := $(CURDIR)
> >  export XEN_ROOT := $(BASEDIR)/..
> >  
> >  EFI_MOUNTPOINT ?= /boot/efi
> > +XEN_BOOT_DIR ?= /boot
> 
> Did it not occur to you that the immediately preceding line then
> would also need changing? I'm also not certain about the need for
> the XEN_ prefix on the new variable - there's nothing Xen-specific
> about the location of the boot directory/partition.

Why would EFI_MOUNTPOINT need a change? If it does not fit it can be
changed at build time. But I'm fine with something like

BOOT_DIR ?= /boot
EFI_MOUNTPOINT ?= $(BOOT_DIR)/efi

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel