|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RFC 09/23] lz4: add support for OSes that don't have asm/unaligned.h
On 22/04/14 17:55, Ian Campbell wrote: > On Tue, 2014-04-22 at 16:46 +0200, Roger Pau Monnà wrote: >> Anyway, I think this patch and the preceding one are plain wrong, what >> we should do is completely remove the bogus dependence on >> asm/unaligned.h, which is a Linux specific header file, and open-code >> what we need. > > Am I right that for libxc's lz4 support we are using the Linux kernel's > built in decompression code, instead of the relevant userspace library > as we do for most other compression algorithms? No, I don't think we are using Linux kernel's built in decompression code, but we are using some non-standard functions, like __get_unaligned, which are only defined in Linux's asm/unaligned.h. IMHO, we should get rid of the include of asm/unaligned.h and code whatever functions we need from that file in a portable way. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |