Re: [Xen-devel] [PATCH RFC 09/23] lz4: add support for OSes that don't have asm/unaligned.h

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monné writes ("Re: [PATCH RFC 09/23] lz4: add support for OSes that 
don't have asm/unaligned.h"):
> On 17/04/14 19:00, Ian Jackson wrote:
> > Roger Pau Monne writes ("[PATCH RFC 09/23] lz4: add support for OSes that 
> > don't have asm/unaligned.h"):
> >> Add a configure check for asm/unaligned.h presence, and if it's not
> >> available open-code the necessary functions for lz4.
> > 
> > Where did this code come from ?
> 
> This came from the Linux kernel, see:
> 
> http://lxr.free-electrons.com/source/include/asm-generic/unaligned.h?v=2.6.25#L80

I think you should mention this in the commit message.  (Including
mentioning the specific Linux version or changeset the file came
from.)

> Anyway, I think this patch and the preceding one are plain wrong, what
> we should do is completely remove the bogus dependence on
> asm/unaligned.h, which is a Linux specific header file, and open-code
> what we need.
> 
> I'm CCing the people that added the LZ4 support to Xen, let's see if
> they can shed some light on this.

OK.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel