Re: [Xen-devel] [PATCH v6 07/11] xen, common: move the memory_mapping DOMCTL hypercall to common code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.04.14 at 15:45, <avanzini.arianna@xxxxxxxxx> wrote:
> +        else
> +        {
> +            int tmp_rc = 0;

Pointless initializer. Also no apparent reason for the tmp_ prefix.

> --- a/xen/include/asm-arm/p2m.h
> +++ b/xen/include/asm-arm/p2m.h
> @@ -51,6 +54,8 @@ typedef enum {
>  #define p2m_is_foreign(_t)  ((_t) == p2m_map_foreign)
>  #define p2m_is_ram(_t)      ((_t) == p2m_ram_rw || (_t) == p2m_ram_ro)
>  
> +void memory_type_changed(struct domain *d);

The function becoming common should result in its declaration to move
to a common header rather than being replicated in each arch. The
more that you move the {,un}map_mmio_regions() declarations this
way already.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel