Re: [Xen-devel] [OSSTEST PATCH] cr-daily-branch: Print better message re lack of push

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-04-17 at 16:43 +0100, Ian Jackson wrote:
> Ian Jackson writes ("[OSSTEST PATCH] cr-daily-branch: Print better message re 
> lack of push"):
> > wantpush might be false because
> >  - OSSTEST_PUSH is false (only set to true in daily-cron-settings-real)
> >  - baseline untested (what we had here)
> >  - "$tree" is unknown (although I think this would fail elsewhere)
> >  - input and output revisions are the same
> > 
> > Print the message "Published tested tree is already up to date" only
> > if that's actually the case.
> 
> I haven't tested this (and it's not easy to test all the cases).
> Instead, I'd appreciate a careful code review of this small change.

I did test at part of my libvirt branch provisioning runs, and it
appears to do the right thing.

It also appears correct to me by inspection, apart from the mix of hard
and soft tabs.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel