Re: [Xen-devel] [PATCH v3 2/5] tools/libxc: Make the mem_access APIs generic

[Tamas Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Thu, Apr 17, 2014 at 5:52 PM, Aravindh Puthiyaparambil (aravindp) <aravindp@xxxxxxxxx> wrote:

>       diff --git a/tools/libxc/xenctrl.h b/tools/libxc/xenctrl.h
>       index e3a32f2..3513ddb 100644
>       --- a/tools/libxc/xenctrl.h
>       +++ b/tools/libxc/xenctrl.h
>       @@ -2059,8 +2059,22 @@ int xc_mem_paging_load(xc_interface
>*xch, domid_t domain_id,
>         */
>        int xc_mem_access_enable(xc_interface *xch, domid_t domain_id,
>uint32_t *port);
>        int xc_mem_access_disable(xc_interface *xch, domid_t domain_id);
>       -int xc_mem_access_resume(xc_interface *xch, domid_t domain_id,
>       -                         unsigned long gfn);
>       +int xc_mem_access_resume(xc_interface *xch, domid_t
>domain_id);
>       +
>       +/*
>       + * Set a range of memory to a specific access.
>       + * Allowed types are XENMEM_access_default, XENMEM_access_n,
>any combination of
>       + * XENMEM_access_ + (rwx), and XENMEM_access_rx2rw
>       + */
>
>
>
>What about XENMEM_access_n2rwx?

That should work too. The patch does add or remove any functionality. I just copied the API description over from the original xc_hvm_set_mem_access(). So whoever added access_n2rwx did not update the description. I have more patches in this area so I will update it in the next go around or you can submit a patch once this one goes in.

Thanks,
Aravindh

If you are already at it, might as well fix the comment too.

Thanks!

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel