[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v5 2/2] allow hardware domain != dom0
>>> On 16.04.14 at 20:56, <dgdegra@xxxxxxxxxxxxx> wrote: Actually when preparing to commit this I realized this is done rather badly: > +void rangeset_swap(struct rangeset *a, struct rangeset *b) > +{ > + struct list_head tmp; Blank line missing here. > + if ( a < b ) > + { > + spin_lock(&a->lock); > + spin_lock(&b->lock); > + } > + else > + { > + spin_lock(&b->lock); > + spin_lock(&a->lock); > + } > + memcpy(&tmp, &a->range_list, sizeof(tmp)); > + memcpy(&a->range_list, &b->range_list, sizeof(tmp)); > + memcpy(&b->range_list, &tmp, sizeof(tmp)); > + if ( a->range_list.next == &b->range_list ) > + { > + a->range_list.next = &a->range_list; > + a->range_list.prev = &a->range_list; > + } > + else > + { > + a->range_list.next->prev = &a->range_list; > + a->range_list.prev->next = &a->range_list; > + } > + if ( b->range_list.next == &a->range_list ) > + { > + b->range_list.next = &b->range_list; > + b->range_list.prev = &b->range_list; > + } > + else > + { > + b->range_list.next->prev = &b->range_list; > + b->range_list.prev->next = &b->range_list; > + } I think all this can be replaced with two list_splice_init() and one final list_splice(); no need to open code any list manipulation. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |