Re: [Xen-devel] [PATCH xen v3] xen: arm: fully implement multicall interface.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-04-17 at 15:00 +0100, Julien Grall wrote:
> On 04/17/2014 01:57 PM, Ian Campbell wrote:
> >  void do_multicall_call(struct multicall_entry *multi)
> >  {
> >      arm_hypercall_fn_t call = NULL;
> > @@ -1176,9 +1196,13 @@ void do_multicall_call(struct multicall_entry *multi)
> >          return;
> >      }
> >  
> > +    if ( is_32bit_domain(current->domain) &&
> > +         !check_multicall_32bit_clean(multi) )
> > +        return;
> > +
> 
> With this solution, you continue to go through the other multicall.
> Shouldn't we return an error here and exit the loop in do_multicall?

See the previous discussion with Jan on v2, calling domain_crash will
cause do_multicall to be preempted.

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel