Re: [Xen-devel] [PATCH] xen: use sync_clear_bit instead of clear_bit

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 17/04/14 09:41, Vladimir Murzin wrote:
> Signed-off-by: Vladimir Murzin <murzin.v@xxxxxxxxx>
> ---
>  For those who whant to play with original issue [1]
>  
>  [1] http://www.gossamer-threads.com/lists/xen/devel/325613
> 
>  drivers/xen/events/events_fifo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/events/events_fifo.c 
> b/drivers/xen/events/events_fifo.c
> index 96109a9..91248d8 100644
> --- a/drivers/xen/events/events_fifo.c
> +++ b/drivers/xen/events/events_fifo.c
> @@ -273,7 +273,7 @@ static void consume_one_event(unsigned cpu,
>        * copy of the ready word.
>        */
>       if (head == 0)
> -             clear_bit(priority, BM(ready));
> +             sync_clear_bit(priority, BM(ready));

I prefer the fix that makes ready an unsigned long.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel