Re: [Xen-devel] [PATCH v4 2/2] tools/libxl: Improvements to libxl-save-helper when using valgrind

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-11 at 16:57 +0100, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH v4 2/2] tools/libxl: Improvements to 
> libxl-save-helper when using valgrind"):
> > Fix two unfree()'d allocations in libxl-save-helper, to get them out of the
> > way of other legitimate complaints from valgrind.
> > 
> > The first is easy; close the interface to libxc when done with it.
> > 
> > The second can be fixed by removing the complexity of creating the logging
> > instance.  Initialise the global 'logger' in place rather than as an
> > allocation, which requires changing the indirection of its use in 5 
> > locations.
> > 
> > struct xentoollog_logger_tellparent and function createlogger_tellparent() 
> > are
> > now unused and removed.
> 
> Great, thanks.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

APplied both.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel