Re: [Xen-devel] [PATCH v3 17/18] xen/arm: IRQ: extend {request, setup}_irq to take an irqflags in parameter

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Jan,

On 04/08/2014 03:58 PM, Jan Beulich wrote:
>>>> On 08.04.14 at 16:44, <julien.grall@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -949,7 +949,7 @@ static int __init irq_ratelimit_init(void)
>>  }
>>  __initcall(irq_ratelimit_init);
>>  
>> -int __init request_irq(unsigned int irq,
>> +int __init request_irq(unsigned int irq, unsigned int irqflags,
>>          void (*handler)(int, void *, struct cpu_user_regs *),
>>          const char * devname, void *dev_id)
>>  {
>> @@ -976,7 +976,7 @@ int __init request_irq(unsigned int irq,
>>      action->dev_id = dev_id;
>>      action->free_on_release = 1;
>>  
>> -    retval = setup_irq(irq, action);
>> +    retval = setup_irq(irq, 0, action);
> 
> You should be passing irqflags here.

Oops right. I will fix it in the next version of this series.

> With that, for x86 and IOMMU:
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel