Re: [Xen-devel] [PATCH v3 10/18] xen/arm: IRQ: Require desc.lock held by callers of hw_irq_controller callbacks

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/16/2014 04:36 PM, Ian Campbell wrote:
> On Tue, 2014-04-08 at 15:43 +0100, Julien Grall wrote:
>> When multiple action are supported, gic_irq_{startup,shutdown} will have
>> to be called in the same critical section as setup/release.
>> Otherwise there is a race condition if at the same time CPU A is calling
>> release_dt_irq and CPU B is calling setup_dt_irq.
>>
>> This could end up with the IRQ not being enabled.
>>
>> At the same time, modify gic_irq_{enable,disable} to require desc.lock held.
> 
> "require that ... is held" or "require ... be held".

I guess, I also have to update the commit title, rigth?

I plan to change into:

"Require desc.lock be held by callers of hw_irq_controller callbacks"

>>
>> With this both changes, ARM's locking requirements is the same as x86's.
> 
> "With both of these changes..."
> 
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel