Re: [Xen-devel] [PATCH v2 03/10] hvm/hpet: Only set comparator or period not both.

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 04/15/14 02:59, Jan Beulich wrote:
> > > > On 15.04.14 at 00:53, <dslutz@xxxxxxxxxxx> wrote:
> Yes, with a minor comment.
...

> > +            if ( timer_is_32bit(h, tn) )
> > +                h->hpet.timers[tn].cmp = (uint32_t)new_val;
> > +            else
> > +                h->hpet.timers[tn].cmp = new_val;
> I'd continue to do the truncation on new_val, and write just once
> (as the old code did).
Will do in v3.
    -Don Slutz

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel