Re: [Xen-devel] [PATCH] xen/pci: Remove unused dev_err() string

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, Apr 14, 2014 at 04:25:23PM -0600, Bjorn Helgaas wrote:
> We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or
> BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case.
> 
> Found by Coverity (CID 146520).

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

David, are you OK pushing this in 'devel/for-linus-3.14'?

Thanks!
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> ---
>  drivers/xen/pci.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
> index dd9c249ea311..59a25f937bd7 100644
> --- a/drivers/xen/pci.c
> +++ b/drivers/xen/pci.c
> @@ -177,8 +177,7 @@ static int xen_pci_notifier(struct notifier_block *nb,
>       }
>       if (r)
>               dev_err(dev, "Failed to %s - passthrough or MSI/MSI-X might 
> fail!\n",
> -                     action == BUS_NOTIFY_ADD_DEVICE ? "add" :
> -                     (action == BUS_NOTIFY_DEL_DEVICE ? "delete" : "?"));
> +                     action == BUS_NOTIFY_ADD_DEVICE ? "add" : "del");
>       return NOTIFY_OK;
>  }
>  
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel