[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 07/10] hvm/hpet: Call hpet_get_comparator during hpet_save.
>>> On 15.04.14 at 02:21, <dslutz@xxxxxxxxxxx> wrote: > On 04/14/14 11:13, Jan Beulich wrote: >>>>> On 08.04.14 at 16:24, <dslutz@xxxxxxxxxxx> wrote: >>> This changes save data to consistent/expected values. It is not >>> technically required because hpet_get_comparator() will adjust from >>> any value to the correct value. >> So am I getting it right that this is just to alter what's in the save image >> then? > > Yes. > >> I'm somewhat confused by the wording above, which I first read >> mostly like "here is a change that we don't need". > > This is a change that is only "needed" with patch #10 > "handle 1st period special". > > However it does look strange to people > that the output from xen-hvmctx for the comparator > values do not change when the master clock does. Maybe you should mention that aspect then in the commit message? Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |