Re: [Xen-devel] [PATCH V2 3/4] libxl/gentypes.py: generate empty map for None field in keyed-union

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Apr 14, 2014 at 06:08:50PM +0100, Ian Campbell wrote:
> On Mon, 2014-04-14 at 17:59 +0100, Wei Liu wrote:
> > On Mon, Apr 14, 2014 at 05:53:11PM +0100, Ian Campbell wrote:
> > > On Thu, 2014-04-10 at 16:26 +0100, Wei Liu wrote:
> > > > Without this the generated JSON is malformed.
> > > > 
> > > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > 
> > > Hold on the Ack...
> > > 
> > > > +            else:
> > > > +                s += "    yajl_gen_map_open(hand);\n"
> > > 
> > > ITHM s =...
> > > 
> > > > +                s += "    if (s != yajl_gen_status_ok)\n"
> > > > +                s += "        goto out;\n"
> > > > +                s += "    yajl_gen_map_close(hand);\n"
> > > 
> > > and again.
> > > 
> > > Spotted because the diff of the generated code across the entire series
> > > was as below, the spurious change is pretty obvious in the third hunk.
> > > 
> > 
> > I should've stolen your handy script earlier!
> 
> ~ianc/xen-build-tools/libxl-idl-* if you still want to...
> 
> > This one should be correct.
> 
> Agreed, you can have that Ack back ;-)
> 

Do you want me to resend the whole series with all Acks folded in?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel