Re: [Xen-devel] [PATCH V2 4/4] libxl_types.idl: replace empty Struct with None for libxl_event

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Apr 14, 2014 at 05:49:35PM +0100, Ian Campbell wrote:
> On Thu, 2014-04-10 at 16:26 +0100, Wei Liu wrote:
> > Now we generate empty map for None, the empty Struct trick is not
> > necessary anymore.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> But you've missed
>             ("domain_death", Struct(None, [])),
> in the same struct.

Oops. My fault.

> 
> Arguably this is an API change -- but since the struct was 
>         struct {
>                 } domain_create_console_available;
> 
> I don't think it is material enough to warrant a #define etc.


---8<---
From 2cfa7a3623847a431c0bf662a19e9eb2d9c79254 Mon Sep 17 00:00:00 2001
From: Wei Liu <wei.liu2@xxxxxxxxxx>
Date: Thu, 10 Apr 2014 16:20:22 +0100
Subject: [PATCH] libxl_types.idl: replace empty Struct with None for
 libxl_event

Now we generate empty map for None, the empty Struct trick is not
necessary anymore.

Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
 tools/libxl/libxl_types.idl |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
index 612645c..0f7bbf8 100644
--- a/tools/libxl/libxl_types.idl
+++ b/tools/libxl/libxl_types.idl
@@ -588,7 +588,7 @@ libxl_event = Struct("event",[
           [("domain_shutdown", Struct(None, [
                                              ("shutdown_reason", uint8),
                                       ])),
-           ("domain_death", Struct(None, [])),
+           ("domain_death", None),
            ("disk_eject", Struct(None, [
                                         ("vdev", string),
                                         ("disk", libxl_device_disk),
@@ -596,5 +596,5 @@ libxl_event = Struct("event",[
            ("operation_complete", Struct(None, [
                                         ("rc", integer),
                                  ])),
-           ("domain_create_console_available", Struct(None, [])),
+           ("domain_create_console_available", None),
            ]))])
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel