Re: [Xen-devel] [PATCH V2 2/2] ts-debian-hvm-install: fix guest memory size

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH V2 2/2] ts-debian-hvm-install: fix guest memory size"):
> If the host has more than 5G free memory, change guest memory size to 5G
> to catch any error that triggers by crossing 4G boundary. Otherwise
> guest memory size is set to 768 MB (taken from ts-redhat-install) which
> should be a safe value to run this testcase on every host.

Thanks.  I just have nits to complain about in this one.

> -our $ram_mb=   6000;
> +# guest memory size will be set based on host free memory, see below
> +our $ram_mb=      0;

Why do you initialise this to 0 ?

> +# If host has >5G free memory, create a guest with 5G memory to catch any er
ror
> +# that triggers cross 4G boundary

This comment could do with wrapping to 70ish rather than exactly 80,
so that it is readable even with the "+" in front and when quoted.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel