Re: [Xen-devel] [PATCH v2 06/10] hvm/hpet: comparator can only change when master clock is enabled.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.04.14 at 16:24, <dslutz@xxxxxxxxxxx> wrote:
> This is based on software-developers-hpet-spec-1-0a.pdf saying:
> 
> When the main counter value matches the value in the timer's
> comparator register, an interrupt can be generated.  The hardware
> will then automatically increase the value in the compare register
> by the last value written to that register.
> 
> And since interrupt can only be generated when the master clock
> is enabled.

This last sentence looks truncated.

As to the change - I'm not sure: The quoted description from the
specification cal also be read to mean that interrupt generation is
optional, but comparator increment will always happen. As long as
this can't be clarified, I'd prefer to stay with the code as is.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel