Re: [Xen-devel] [PATCH v2 02/10] hvm/hpet: Only call guest_time_hpet(h) one time per action.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.04.14 at 16:24, <dslutz@xxxxxxxxxxx> wrote:

This looks good to me, just a minor comment:

> -static void hpet_set_timer(HPETState *h, unsigned int tn)
> +static void hpet_set_timer(HPETState *h, unsigned int tn, int mc_starting)

This as well as ...

> @@ -283,6 +291,7 @@ static int hpet_write(
>  #define set_stop_timer(n)    (__set_bit((n), &stop_timers))
>  #define set_start_timer(n)   (__set_bit((n), &start_timers))
>  #define set_restart_timer(n) (set_stop_timer(n),set_start_timer(n))
> +    int mc_starting = 0;

... this wants to be bool_t. Or alternatively you might want to see
whether just like in the other case you could pass guest_time in.

With that adjusted,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel