Re: [Xen-devel] [PATCH] tools/libxc: Remove -DVALGRIND from libxc

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-11 at 16:57 +0100, Andrew Cooper wrote:
> It is not used at all in tree, and its justifaction is out of date now that

"justification"

> Xen hypercall support exists upstream in valgrind.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
>  tools/libxc/Makefile     |    4 ----
>  tools/libxc/xc_private.c |    9 ---------
>  tools/libxc/xc_private.h |   11 -----------
>  tools/libxc/xc_tmem.c    |   10 ----------
>  4 files changed, 34 deletions(-)
> 
> diff --git a/tools/libxc/Makefile b/tools/libxc/Makefile
> index 2cca2b2..a74b19e 100644
> --- a/tools/libxc/Makefile
> +++ b/tools/libxc/Makefile
> @@ -95,10 +95,6 @@ CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
>  
>  CFLAGS       += $(PTHREAD_CFLAGS)
>  
> -# Define this to make it possible to run valgrind on code linked with these
> -# libraries.
> -#CFLAGS   += -DVALGRIND -O0 -ggdb3

You are removing more than -DVALGRIND here.

Perhaps those removals are justified but the changelog should do so.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel