Re: [Xen-devel] [PATCH v2 14/15] xen/arm: Add vgic support for GIC v3

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Thu, Apr 10, 2014 at 5:38 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Thu, 2014-04-10 at 17:08 +0530, Vijay Kilari wrote:
>> On Thu, Apr 10, 2014 at 4:56 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> 
>> wrote:
>> > On Thu, 2014-04-10 at 16:49 +0530, Vijay Kilari wrote:
>> >
>> >> I mean, I don't have V2 hardware to test any trivial changes that I do to
>> >> GIC v2. In all my patches, I am not making any changes to functionality of
>> >> v2 except code movement and changing names
>> >
>> > I can test it if necessary. Do you have access to fast models or
>> > anything similar?
>>
>> Currently I don't have one. I can setup.
>> Is it ok if I investigate on this later separately?
>
> I'm afraid that I don't want to add duplicated code to be cleaned up
> later. If this stuff can be shared then it should be done from the
> start. (These things have a habit of not happening otherwise).
>
Let me attempt and send a patch.
However I feel except vgic_distr_mmio_read & vgic_distr_mmio_write of
gicv2 code,
we can move all other functions to either header file (new file
vgic.h) or common code file (vgic.c)
which can be shared with gicv3.This is the simplest approach I think.

Also, in GICD, few register are changed between v2 & v3 ex: GICD_IROUTER

> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel