Re: [Xen-devel] [PATCH v2 07/15] xen/arm: split gic driver into generic and gic-v2 driver

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Thu, Apr 10, 2014 at 2:28 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Fri, 2014-04-04 at 17:26 +0530, vijay.kilari@xxxxxxxxx wrote:
>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>
>> Existing GIC driver has both generic code and hw specific
>> code. Segregate GIC low level driver into gic-v2.c and
>> keep generic code in existing gic.c file
>
> This is substantially just code motion, correct?
>
  Yes, but now I think to avoid confusion I will make single
patch for spliting v2 driver & code movement as in V1

> I notice that gicv2_init does not hold the gic lock while calling +
> gic_{dist,cpu,hyp}_init(), is that intentional?
>
>> +static struct gic_hw_operations gic_ops;
>
> If you order this file:
>         callbacks
>         gic_hw_ops
>         gicv2_init
>
Yes, this is called only during init by boot cpu and is not called by
any other cpu
So, I have not taken the lock.

> Then you can avoid this forward declaration and more importantly you can
> probably mark the struct as const.
>
> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel