Re: [Xen-devel] [PATCH RFC 2/2] tools/libxc: Make the mem_access APIs generic

["Aravindh Puthiyaparambil (aravindp)" <aravindp@xxxxxxxxx>]

>> @@ -47,12 +47,59 @@ int xc_mem_access_disable(xc_interface *xch,
>domid_t domain_id)
>>                                  NULL);
>>  }
>>
>> +static int xc_mem_access_memop(xc_interface *xch, domid_t domid,
>> +                               xen_mem_access_op_t *mao)
>> +{
>> +    mao->domid = domid;
>> +
>> +    return do_memory_op(xch, XENMEM_access_op, mao, sizeof(*mao));
>
>I'm not sure what this wrapper is bringing to the table over just making
>the call in the callers. Also you inconsistently do and don't set
>mao->domid in the callers. If you want to keep the wrapper then I'd
>suggest making the callers set domid along with all the other fields and
>dropping the domid argument here.

The wrapper is indeed pointless. I will get rid of it.

Thanks,
Aravindh
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel