Re: [Xen-devel] [PATCH v2 03/15] arm/xen: move gic save and restore registers to gic driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-04 at 17:26 +0530, vijay.kilari@xxxxxxxxx wrote:

> gic saved registers are moved to gic driver.
> This required structure is allocated at runtime
> and is saved & restored.

I don't follow why this change required switch to allocating them
dynamically. If it is a v2 vs v3 thing then I think a union in struct
arch_vcpu would be fine, unless the v3 stuff is relatively enormous.

> -    v->arch.gic_apr = GICH[GICH_APR];
> -    v->arch.gic_vmcr = GICH[GICH_VMCR];
> +    v->arch.gic_state->gic_apr = GICH[GICH_APR];
> +    v->arch.gic_state->gic_vmcr = GICH[GICH_VMCR];

I think the gic on the field name is now redundant, at I reckon you can
drop _state too.

IOW v->arch.gic->apr, v->arch.gic->vmcr, etc.

(or v->arch.gic.v2.apr / v->arch.gic_v2.apr based on the first comment)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel