[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 01/15] xen/arm: register mmio handler at runtime
On Fri, 2014-04-04 at 18:00 +0530, Vijay Kilari wrote: > >> +void register_mmio_handler(struct domain *d, struct mmio_handler * > >> handle); > > > > As I said on the previous version, it would be nice to remove check > > callback in the mmio_handler and replace it by addr/size. It's better if > > we might want to change the place in the memory following the guest. > > > > So the result function would be: > > > > register_mmio_handler(struct domain *d, read_t read, write_t write, > > addr, size); > > > OK. Regardless of addr+size vs check() I don't think it is necessary to explode struct mmio_handler into separate arguments here, passing a pointer to the static struct in each driver seems much nicer. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |