Re: [Xen-devel] [PATCH v4 6/8] ioreq-server: remove p2m entries when server is enabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.04.14 at 15:36, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Also, you're pretty consistently naming the field/variable "enabled"
>> rather than "enable", despite it being a transition you're invoking
>> rather than obtaining state.
> 
> Yes, because I'm setting whether the server state is 'enabled' or not. The 
> value of the boolean is the end state not the transition, so it's correct to 
> use the adjective rather than the verb.

Hmm, that's not my way of thinking with operations like this. To me,
the operation is to enable (or disable) the server, not to set its state
to enabled (or disabled). But yes, one may view it your way too,
even if I would think that's not commonly done (and I think I saw
"enable"s too somewhere in the series, and maybe even in the same
patch, so I'd be inclined to ask for consistency even if our ways of
thinking of these operations differ).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel