Re: [Xen-devel] [PATCH 1/3] tools: arm: improve placement of initial modules.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-04-09 at 13:43 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 04/09/2014 12:51 PM, Ian Campbell wrote:
> > 314c9815e2f5 "tools: implement initial ramdisk support for ARM." broke 
> > starting
> > guests with <= 128 MB ram by placing the boot modules (dtb and initrd)
> > immediately after the kernel in this case, running the risk of them being
> > overwritten. Instead place the modules at the end of RAM, as the hypervisor
> > does for dom0.
> > 
> > The hypervisor also falls back to placing things before the kernel as a last
> 
> Did you mean "falls backs on placing"?

"Falls back to X" is also correct, "on" might be but reads strangely to
me in this particular context.

> Other than that the patch looks good to me:
> 
> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Thanks.

> Regards,
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel