[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [V1 PATCH 1/3] Rename public functions in p2m-pt.c
>>> On 09.04.14 at 03:47, <mukesh.rathor@xxxxxxxxxx> wrote: > @@ -870,9 +870,9 @@ long p2m_pt_audit_p2m(struct p2m_domain *p2m) > /* Set up the p2m function pointers for pagetable format */ > void p2m_pt_init(struct p2m_domain *p2m) > { > - p2m->set_entry = p2m_set_entry; > - p2m->get_entry = p2m_gfn_to_mfn; > - p2m->change_entry_type_global = p2m_change_type_global; > + p2m->set_entry = p2m_pt_set_entry; > + p2m->get_entry = p2m_pt_gfn_to_mfn; Considering the left side of this, I'd prefer the function to be named p2m_pt_get_entry, allowing all variants to be found with e.g. a suitable expression passed to grep. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |