Re: [Xen-devel] [PATCH 2/4] xen: arm: move magic pfns out of guest RAM region

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 04/08/2014 03:19 PM, Ian Campbell wrote:
> Because toolstacks (at least libxl) only allow RAM to be specified in 1M
> increments these two pages were effectively costing 1M of guest RAM space.
> 
> Since these pages don't actually need to live in RAM just move them out.
> 
> With this a guest can now use the full 768M of the address space reserved
> for RAM. (ok, not that impressive, but it simplifies things later)
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  tools/libxc/xc_dom_arm.c      |   10 +++++-----
>  xen/include/public/arch-arm.h |    2 ++
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c
> index c085b4a..36b1487 100644
> --- a/tools/libxc/xc_dom_arm.c
> +++ b/tools/libxc/xc_dom_arm.c
> @@ -58,12 +58,12 @@ static int setup_pgtables_arm(struct xc_dom_image *dom)
>  static int alloc_magic_pages(struct xc_dom_image *dom)
>  {
>      int rc, i;
> +    const xen_pfn_t base = GUEST_MAGIC_BASE >> PAGE_SHIFT;
>      xen_pfn_t p2m[NR_MAGIC_PAGES];
> -

Spurious change?

Apart this minor question:
Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel