[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen/arm32: __cmpxchg_mb should be marked always_inline
On Thu, 2014-04-03 at 18:09 +0100, Julien Grall wrote: > Currently __cmpxchg_mb is only marked inline. The compiler can decide to not > inline this function. In this case, the call to __cmpxchg will be inlined > but not optimised. This will result linking failure because of __bad_cmpxchg. > > Catched by clang 3.5. "caught". Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> But there is no S-o-b. If you offer one here I'll fix the spelling as I commit. > --- > xen/include/asm-arm/arm32/cmpxchg.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/xen/include/asm-arm/arm32/cmpxchg.h > b/xen/include/asm-arm/arm32/cmpxchg.h > index 70c6090..3f4e7a1 100644 > --- a/xen/include/asm-arm/arm32/cmpxchg.h > +++ b/xen/include/asm-arm/arm32/cmpxchg.h > @@ -112,8 +112,9 @@ static always_inline unsigned long __cmpxchg( > return oldval; > } > > -static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long > old, > - unsigned long new, int size) > +static always_inline unsigned long __cmpxchg_mb(volatile void *ptr, > + unsigned long old, > + unsigned long new, int size) > { > unsigned long ret; > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |