Re: [Xen-devel] [V8 PATCH 5/8] pvh dom0: Add and remove foreign pages

[Tim Deegan <tim@xxxxxxx>]

At 08:36 +0100 on 08 Apr (1396942615), Jan Beulich wrote:
> >>> On 08.04.14 at 03:11, <mukesh.rathor@xxxxxxxxxx> wrote:
> > On Mon, 07 Apr 2014 07:57:56 +0100
> > "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> >> In the end I think we'll want to make them all report proper error
> >> codes...
> > 
> > Ok, how about the following patch then? If it's OK, I'd like to submit
> > independently.
> 
> Yes, I just now stumbled across this oddity too. Looks generally
> like what we want

While in general I like this, I'm worried about inverting the sense of
the return code -- that seems like setting a trap for ourselves with
backporting patches past this one.

I'd be inclined to change the name of the function as a safety catch,
though I can't immediately think of a good new name for set_p2m_entry.
Maybe just truncate it to set_p2m()?

Tim.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel