[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH xen v2] xen: arm: fully implement multicall interface.
On Tue, 2014-04-08 at 14:08 +0100, Jan Beulich wrote: > >>> On 08.04.14 at 13:39, <Ian.Campbell@xxxxxxxxxx> wrote: > > Actually, you mentioned preempt. Does calling domain_crash() cause > > hypercall_preempt_check to return true? In that case do_multicall > > already does the right thing. That would involve domain_crash either > > causing a softirq or an evtchn upcall, which I don't see it doing > > though. Perhaps just adding a d->is_shutting_down check alongside the > > preempt check in the multicall would do the trick. > > Good point. And yes, a softirq is being raised implicitly: > domain_shutdown() calls vcpu_pause_nosync() for all the domain's > vCPU-s, which - via vcpu_sleep_nosync() - reaches the ->sleep() > callback of the individual schedulers, all of which raise the schedule > softirq if the subject vCPU is the one they're running on. That's good enough for me, I'll switch to domain_crash+return without worrying about the rest of the entries messing up the console. Cheers, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |