[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 11/16] xen/arm: IRQ: Protect IRQ to be shared between domains and XEN
On 04/07/2014 03:46 PM, Ian Campbell wrote: > On Thu, 2014-04-03 at 21:42 +0100, Julien Grall wrote: > > $subject "do not allow IRQs to be shared between..." I will change the commit title. >> The current dt_route_irq_to_guest implementation set IRQ_GUEST no matter if >> the > > s/set/sets/; s/no matter if/even if/ > >> IRQ is correctly setup. > > "is already correctly setup" (I think that's what you meant) > >> As IRQ can be shared between devices, if the devices are not assigned to the > > s/As/An/ ? I meant "As an ...". But "An" sounds better with the change below. >> same domain or Xen, this could result to route the IRQ to the domain instead >> of > > "then this could result in routing the IRQ..." >> Xen ... >> >> Also avoid to rely on wrong behaviour when Xen is routing an IRQ to DOM0. > > "Also avoid relying on the wrong behaviour ..." perhaps? If that not > then I'm not sure what this is referring to. Apart from that doubt the > code looks ok to me. Currently Xen doesn't check the return of routing the IRQ into DOM0. So, if it fails we silently ignore the error. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |