[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 08/16] xen/arm: IRQ Introduce irq_get_domain
On 04/07/2014 02:15 PM, Ian Campbell wrote: > On Thu, 2014-04-03 at 21:41 +0100, Julien Grall wrote: >> This function retrieves a domain from an IRQ. It will be used in several >> places (such as do_IRQ) to avoid duplicated code when multiple action will be >> supported. >> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> > > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > >> --- >> Changes in v2: >> - Patch added >> --- >> xen/arch/arm/irq.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c >> index f3a30bd..5111b90 100644 >> --- a/xen/arch/arm/irq.c >> +++ b/xen/arch/arm/irq.c >> @@ -98,6 +98,15 @@ void __cpuinit init_secondary_IRQ(void) >> BUG_ON(init_local_irq_data() < 0); >> } >> >> +static inline struct domain *irq_get_domain(struct irq_desc *desc) >> +{ >> + ASSERT(spin_is_locked(&desc->lock)); >> + ASSERT(desc->status & IRQ_GUEST); > > I don't know if this will be helpful for any of the forthcoming callers > but you could return DOMID_XEN if this isn't the case. This function was created to retrieve easily the domain (mainly when we will switch to a list for the action). As it's only used withing the file and it should only be called when desc->status == IRQ_GUEST, I don't think we need to return DOMID_XEN. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |