[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 07/16] xen/arm: IRQ: Move IRQ management from gic.c to irq.c
On 04/07/2014 02:07 PM, Ian Campbell wrote: > On Thu, 2014-04-03 at 21:41 +0100, Julien Grall wrote: >> The file gic.c contains functions and variables which is not related to the >> GIC: >> - release_irq >> - setup_irq >> - gic_route_irq_to_guest >> - {,local_}irq_desc >> >> Move all theses functions/variables in irq.c and split gic_route_irq_to_guest >> in 2 parts: > > Please can you separate pure code motion from refactoring. > > e.g. You could do the split first leaving route_dt_irq_to_guest in gic.c > and then move it along with everything else. Sure, as the refactoring was simple I didn't create a new patch. >> - route_dt_irq_to_guest: setup the desc >> - gic_route_irq_to_guest: setup correctly the GIC and the desc >> handler >> >> +void release_irq(unsigned int irq) >> +{ >> + struct irq_desc *desc; >> + unsigned long flags; >> + struct irqaction *action; > > Indentation. I've blindly copied for the previous location. I think, I fix the indention on a previous patch. I will fix it here. Regards -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |