Re: [Xen-devel] [PATCH linux v2] arm: xen: implement multicall hypercall support.

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 07/04/14 13:56, Ian Campbell wrote:
> On Mon, 2014-04-07 at 13:51 +0100, David Vrabel wrote:
>> On 07/04/14 13:48, Ian Campbell wrote:
>>> --- a/arch/x86/include/asm/xen/interface.h
>>> +++ b/arch/x86/include/asm/xen/interface.h
>>> @@ -54,6 +54,9 @@ typedef unsigned long xen_pfn_t;
>>>  #define PRI_xen_pfn "lx"
>>>  typedef unsigned long xen_ulong_t;
>>>  #define PRI_xen_ulong "lx"
>>> +typedef long xen_long_t;
>>> +#define PRI_xen_long "lx"
>>
>> Do you really want signed values to be printed as unsigned?
> 
> There's no signed hex format code (is there?) so it was a choice between
> signed decimal or unsigned hex, I went with the latter for consistency
> with PRI_xen_ulong.
> 
> In the absence of a PRIx64 vs PRId64 type distinction there's probably
> no universally correct answer.

Ok.

Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel