Re: [Xen-devel] [PATCH v5 08/10] xen/arm: second irq injection while the first irq is still inflight

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sun, 2014-04-06 at 17:58 +0100, Stefano Stabellini wrote:

> I realize now that the current naming scheme could be confusing.  When I
> talk about pending, active and GICH_LR_PENDING in this commit message, I
> am talking about the irq status in the LR register. When I talk about
> GIC_IRQ_GUEST_PENDING, I am referring to the GIC internal state tracker.
> 
> Because we don't actually know when the guest irq goes from pending to
> active, we are clearing GIC_IRQ_GUEST_PENDING as soon as we add an irq
> to an LR, as stated in the comment in xen/include/asm-arm/domain.h.
> However as a result GIC_IRQ_GUEST_PENDING is more like
> "GIC_IRQ_GUEST_QUEUED" rather than "GIC_IRQ_GUEST_PENDING", like you
> wrote.
> 
> I'll add a patch to do the renaming as suggested.

Thanks, in that case I guess I won't need the cold towel on my forehead
when I think about this stuff ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel