Re: [Xen-devel] [PATCH v2 04/15] xen/arm: move gic definitions to seperate file

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/04/2014 04:29 PM, Vijay Kilari wrote:
> On Fri, Apr 4, 2014 at 6:57 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
>> Hi Vijaya,
>>
>> Thank you for the patch.
>>
>> On 04/04/2014 12:56 PM, vijay.kilari@xxxxxxxxx wrote:
>>> diff --git a/xen/include/asm-arm/gic_v2_defs.h 
>>> b/xen/include/asm-arm/gic_v2_defs.h
>>> new file mode 100644
>>> index 0000000..f9ff885
>>> --- /dev/null
>>> +++ b/xen/include/asm-arm/gic_v2_defs.h
>>> @@ -0,0 +1,139 @@
>>> +/*
>>> + * ARM Generic Interrupt Controller support v2
>>> + *
>>> + * Vijaya Kumar K <vijaya.kumar@xxxxxxxxxxxxxxxxxx>
>>> + * Copyright (c) 2014 Cavium Inc.
>>
>> I'm not very familiar with copyright in general... but as this is code
>> movement, should not you keep the copyright of Tim?
>>
> I am also not aware it. I kept as it in V1.  You have asked me to change it
> so I did. Anyways, I will put copyright of Tim

Hrm, I read my mail and I didn't ask to modify the copyright...  by
guard I meant include guard:

#ifndef __ASM_ARM_GIC_V2_DEFS_H__
#define __ASM_ARM_GIC_V2_DEFS_H__

your content

#endif /* __ASM_ARM_GIC_V2_DEFS_H__

Without this the header is not protected against multiple inclusion.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel