[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2] tools: implement initial ramdisk support for ARM.
Hi Ian, On 04/04/2014 02:28 PM, Ian Campbell wrote: > struct xc_dom_seg kernel_seg; > + /* If ramdisk_seg.vstart is non zero then the ramdisk will be > + * loaded at that address, otherwise it will automatically placed. > + * > + * If automatic placement is used and the ramdisk is gzip > + * compressed then it will be decompressed as it is loaded. If the > + * ramdisk has been explicitly placed then it is loaded as is > + * itherwise decompressing risks undoing the manual placement. otherwise? [..] > @@ -326,7 +364,6 @@ int xc_dom_feature_translated(struct xc_dom_image *dom) > * mode: C > * c-file-style: "BSD" > * c-basic-offset: 4 > - * tab-width: 4 Does it mean that nearly every emacs magic are wrong on the other files? [..] > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > index 36e70b5..c3fa439 100644 > --- a/tools/libxl/libxl_dom.c > +++ b/tools/libxl/libxl_dom.c > @@ -407,8 +407,8 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid, > LOGE(ERROR, "xc_dom_parse_image failed"); > goto out; > } > - if ( (ret = libxl__arch_domain_configure(gc, info, dom)) != 0 ) { > - LOGE(ERROR, "libxl__arch_domain_configure failed"); > + if ( (ret = libxl__arch_domain_init_hw_description(gc, info, dom)) != 0 > ) { Should not it be ((..))? It seems the function is using 2 different coding style. -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |